fix: remove all .ts files when building in release #4008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building application in release mode, the `.ts` files of all plugins should be removed from the final application. Currently this is happening only for `tns-core-modules`. Do this for all the plugins. Remove logic that deletes the `node_modules` directory of the `tns-core-modules` when it is copied to `platforms`. This is not required anymore and it breaks use-case when linking tns-core-modules.
Fatme
reviewed
Oct 10, 2018
| for (const entry in dependencies) { | ||
| const dependency = dependencies[entry]; | ||
| public copyModules(opts: { dependencies: IDependencyData[], release: boolean }): void { | ||
| const filePatternsToDelete = opts.release ? "**/*.ts" : "**/*.d.ts"; |
There was a problem hiding this comment.
Should we exclude .scss files here as well?
There was a problem hiding this comment.
I was thinking the same, but it is not a common practice to publish packages with .scss ,while all plugins have .d.ts. We need a more generic way to handle this and let the user decides what to exclude.
Fatme
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building application in release mode, the
.tsfiles of all plugins should be removed from the final application. Currently this is happening only fortns-core-modules. Do this for all the plugins.Remove logic that deletes the
node_modulesdirectory of thetns-core-moduleswhen it is copied toplatforms. This is not required anymore and it breaks use-case when linking tns-core-modules.PR Checklist
What is the current behavior?
Applications built in release have
.tsfiles inside them.Also you are unable to use a linked copy of
tns-core-modules.What is the new behavior?
Applications built in release does NOT have
.tsfiles inside them.You can use symlink for tns-core-modules.
Fixes issue #4007